[PATCH] D46893: [CVP] Require DomTree for new Pass Manager

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 18 10:06:44 PDT 2018


spatel added a comment.

I'm happy as long as we have a test.  :)

I haven't stepped through this to understand actually what happens here.

1. In the add.ll file, the new PM crashes. Explain that with a comment in the test file and/or commit message?
2. I don't see any difference in phi-common-val.ll - all of the auto-generated assertions pass even without this patch. Augment the run/assertions to show the failure (if it's visible there some other way)?


https://reviews.llvm.org/D46893





More information about the llvm-commits mailing list