[PATCH] D45549: [DWARF v5] improved support for .debug_rnglists/consumer

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:366
+  if (Error E = RngList.extract(Data, HeaderOffset, End, &Offset)) {
+    llvm::consumeError(std::move(E));
+    return None;
----------------
jhenderson wrote:
> wolfgangp wrote:
> > JDevlieghere wrote:
> > > Would it be worth propagating the error and have this function return an `Expected<>`? 
> > > Would it be worth propagating the error and have this function return an Expected<>?
> > It would improve the reporting on invalid DW_AT_ranges attributes in the DIEs. Seems to require a few more changes in DWARFDie.cpp, but it would be worthwhile. I'll take a look at it.
> > 
> This would be a nice parallel to the work I did on improving the debug line error handling in D44560, and probably something we should keep in mind for any further changes/additions to the DWARF implementation.
I'm inclined to do this in a follow-on patch to keep the number of changes smaller.


https://reviews.llvm.org/D45549