[PATCH] D46896: [llvm-objcopy] Add --strip-unneeded option

[Paul Semel via Phabricator via llvm-commits]

paulsemel added inline comments.


================
Comment at: tools/llvm-objcopy/Object.cpp:264-265
+Symbol *SymbolTableSection::getSymbolByIndex(uint32_t Index) {
+  if (Symbols.size() <= Index)
+    error("Invalid symbol index: " + Twine(Index));
+  return Symbols[Index].get();
----------------
jhenderson wrote:
> I might be inclined to make this check into a separate shared method, to avoid risk of the two diverging.
What do you think about this ?


Repository:
  rL LLVM

https://reviews.llvm.org/D46896