[llvm] r332657 - [AA] cfl-anders-aa with field sensitivity

[George Burgess IV via llvm-commits]

Ideally, yes, but I get the feeling that such a list would never be
entirely complete, and would get out-of-date pretty quickly. :/ (It's also
sort of unclear what 'familiar' should mean -- "have touched file $X"?
"have made many significant contributions to pass $Y", "can LGTM piece $Z
of file $A with confidence," ...?)

Generally, I just bug a code owner (from CODE_OWNERS.TXT) if I'm really
unsure who should get a patch. They're often quite busy, so a response
might not be instant, but between that and blame, finding someone shouldn't
be too terrible. :)

If you're not on the IRC, you can also ask there. Sometimes they'll just
say "blame the file," but many active contributors who know the project
well are somewhat active there.

On Thu, May 17, 2018 at 4:25 PM Dávid Bolvanský <david.bolvansky at gmail.com>
wrote:

> Maybe a simple list of people familiar with certain parts would be helpful
> for new people interested in LLVM contributing? :) We have git blame but...
> many people who changed the lines in the certain file cannot do a real
> review in that part.
>
> 2018-05-18 0:21 GMT+02:00 George Burgess IV <george.burgess.iv at gmail.com>:
>
>> No worries. LLVM is a large project with not-so-well-defined ownership.
>> If someone jumped on my change and LGTM'ed it, I probably would've done the
>> same thing. :)
>>
>> On Thu, May 17, 2018 at 3:06 PM Dávid Bolvanský via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>>
>>> Alright. I dont know persons who can review AA properly so I didnt know
>>> that rja is not familiar with AA.
>>>
>>>
>>> Dňa pi 18. 5. 2018, 0:02 Davide Italiano <davide at freebsd.org>
>>> napísal(a):
>>>
>>>> On Thu, May 17, 2018 at 1:23 PM, David Bolvansky via llvm-commits
>>>> <llvm-commits at lists.llvm.org> wrote:
>>>> > Author: xbolva00
>>>> > Date: Thu May 17 13:23:33 2018
>>>> > New Revision: 332657
>>>> >
>>>> > URL: http://llvm.org/viewvc/llvm-project?rev=332657&view=rev
>>>> > Log:
>>>> > [AA] cfl-anders-aa with field sensitivity
>>>> >
>>>> > Summary:
>>>> > There was some unfinished work started for offset tracking in
>>>> CFLGraph by the author of implementation of Andersen algorithm. This work
>>>> was completed and support for field sensitivity was added to the core of
>>>> Andersen algorithm.
>>>> >
>>>> > The performance results seem promising.
>>>> >
>>>> > SPEC2006 int_base score was increased by 1.1 % (I  compared clang 6.0
>>>> with clang 6.0 with this patch). The avergae compile time was increased by
>>>> +- 1 % according my measures with small and medium C/C++ projects (I did
>>>> not tested it on the large projects with milions of lines of code)
>>>> >
>>>> > Reviewers: chandlerc, george.burgess.iv, rja
>>>> >
>>>> > Reviewed By: rja
>>>> >
>>>>
>>>> This change hasn't been reviewed by anybody familiar with the code. I
>>>> would've given George at least a chance to take a look at this.
>>>>
>>>> --
>>>> Davide
>>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180517/fbfbf8fd/attachment.html>