[llvm] r332636 - [AArch64] preserve test intent by removing undef

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu May 17 11:07:03 PDT 2018


Author: spatel
Date: Thu May 17 11:07:02 2018
New Revision: 332636

URL: http://llvm.org/viewvc/llvm-project?rev=332636&view=rev
Log:
[AArch64] preserve test intent by removing undef

We need to clean up the DAG floating-point undef logic.
This process is similar to how we handled integer undef
logic in D43141.

And as we did there, I'm trying to reduce the patch by
changing tests that would probably become meaningless
once we correct FP undef folding.

Follow-up to:
https://reviews.llvm.org/rL332534
...because that change wasn't enough.

Modified:
    llvm/trunk/test/CodeGen/AArch64/arm64-collect-loh.ll

Modified: llvm/trunk/test/CodeGen/AArch64/arm64-collect-loh.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/arm64-collect-loh.ll?rev=332636&r1=332635&r2=332636&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/arm64-collect-loh.ll (original)
+++ llvm/trunk/test/CodeGen/AArch64/arm64-collect-loh.ll Thu May 17 11:07:02 2018
@@ -672,9 +672,9 @@ if.end.i:
 ; CHECK: .loh AdrpAdrp
 ; CHECK: .loh AdrpLdr
   %mul = fmul double %x, 1.000000e-06
-  %add.i.i.i = fadd double %mul, %mul
-  %sub.i.i = fsub double %add.i.i.i, undef
-  call void (i8*, ...) @callee(i8* getelementptr inbounds ([12 x i8], [12 x i8]* @.str.89, i64 0, i64 0), i8* getelementptr inbounds ([5 x i8], [5 x i8]* @.str.90, i64 0, i64 0), double %sub.i.i)
+  %add = fadd double %mul, %mul
+  %sub = fsub double %add, %add
+  call void (i8*, ...) @callee(i8* getelementptr inbounds ([12 x i8], [12 x i8]* @.str.89, i64 0, i64 0), i8* getelementptr inbounds ([5 x i8], [5 x i8]* @.str.90, i64 0, i64 0), double %sub)
   unreachable
 }
 declare void @callee(i8* nocapture readonly, ...) 




More information about the llvm-commits mailing list