[PATCH] D47020: [Windows, Process] Fix an issue in windows thread handling that was causing LLDB to hang

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp:127-128
+
+    if (previous_suspend_count == -1)
+      return Status(::GetLastError(), eErrorTypeWin32);
   }
----------------
Can you move this check inside the loop and then remove the additional check from the while condition?

Also, can you write `== (DWORD)-1` or `== 0xFFFFFFFF` instead of `== -1`?  It's the same meaning, but it makes it slightly clearer to the reader that this is intentional.


Repository:
  rL LLVM

https://reviews.llvm.org/D47020