[PATCH] D46995: [test-suite] Enable CUDA complex tests with libc++ now that D25403 is resolved.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 17 10:13:56 PDT 2018


tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: External/CUDA/complex.cu:24
 // libstdc++ (compile errors in <complex>).
-#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \
-    (__cplusplus < 201402L || STDLIB_VERSION >= 2014)
+#if __cplusplus >= 201103L && (__cplusplus < 201402L || STDLIB_VERSION >= 2014)
 
----------------
Is this specific to c++14 only, or will we have similar conditions for c++17,20, etc?
Perhaps we could express library version requirements as `STDLIB_VERSION >= (__cplusplus / 100)` ?
I'm OK with either way.




Repository:
  rT test-suite

https://reviews.llvm.org/D46995





More information about the llvm-commits mailing list