[PATCH] D46996: [LICM] Extend the MustExecute scope

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/minor changes

Separately, Serguei, you should try to figure out what the pass ordering problem in our downstream pipeline was that we don't simplify the branches away before we get to LICM.  This patch is definitely useful though, so that's an orthogonal improvement to pursue.



================
Comment at: test/Analysis/MustExecute/const-cond.ll:4
+
+define i1 @const_cond(i32 %high) {
+; CHECK-LABEL: @const_cond(
----------------
Can you add a comment above to indicate the value of this w.r.t. eliminating pass ordering dependencies?


================
Comment at: test/Transforms/LICM/hoist-mustexec.ll:221
 entry:
+; CHECK-LABEL: entry
+; CHECK: %i1 = load i32, i32* %a, align 4
----------------
This isn't the intent of this test.  Can you tweak the test to ensure this keeps testing the negative case?


https://reviews.llvm.org/D46996