[PATCH] D46641: [mips] WIP: Merge MipsLongBranch and MipsHazardSchedule passes

[Simon Dardis via Phabricator via llvm-commits]

sdardis added a comment.
Herald added a subscriber: atanasyan.

LGTM after addressing my comments inline.



================
Comment at: lib/Target/Mips/MipsBranchExpansion.cpp:774
+    longBranchChanged = handlePossibleLongBranch();
+    if (!longBranchChanged) break;
+    forbiddenSlotChanged = handleForbiddenSlot();
----------------
This isn't clang formatted.


================
Comment at: test/CodeGen/Mips/branch-relaxation-with-hazard.ll:1-2
+; RUN: llc -O0 -mcpu=mips32r6 -relocation-model=pic < %s -o - | FileCheck %s --check-prefixes=CHECK,CHECK-PIC
+; RUN: llc -O0 -mcpu=mips32r6 -relocation-model=static < %s -o - | FileCheck %s --check-prefixes=CHECK-STATIC
+
----------------
abeserminji wrote:
> sdardis wrote:
> > Use -mtriple=mips-img-linux-gnu here and use the update_llc_checks.py script on this file.
> I did as suggested, though I am not sure if this is the expected output.
> There are no checks after #APP for both cases.
I see that now. It's to do with inline assembly getting wrapped in .set directives that correspond to the assembly that ends a function. You'll have to go back to your handwritten test instead.


https://reviews.llvm.org/D46641