[PATCH] D46907: [llvm-mca] Introduce a sequential container of Stages

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 17 05:15:30 PDT 2018


courbet added inline comments.


================
Comment at: tools/llvm-mca/Backend.h:22
 #include "Scheduler.h"
+#include "llvm/ADT/SmallVector.h"
 
----------------
andreadb wrote:
> Is this include really needed? You implicitly get it from Dispatch.h
I think it should be included:

https://llvm.org/docs/CodingStandards.html#minimal-list-of-includes

```
You must include all of the header files that you are using
```



https://reviews.llvm.org/D46907





More information about the llvm-commits mailing list