[llvm] r332452 - [SimplifyLibcalls] Replace locked IO with unlocked IO

[Dávid Bolvanský via llvm-commits]

Thanks for fast fix, Benjamin.

2018-05-17 0:09 GMT+02:00 Friedman, Eli <efriedma at codeaurora.org>:

> On 5/16/2018 2:54 PM, Benjamin Kramer via llvm-commits wrote:
>
>> This triggered a really annoying miscompile (see r332531), and it's even
>> present in the test case. Please double check your tests, especially when
>> using update_test_checks.py.
>>
>> Also you want to get these things reviewed by someone who's actually
>> familiar with the LLVM before they land.
>>
>
> I looked at the patch multiple times, and never spotted this issue.
> Granted, maybe I should have looked a little more carefully at that part of
> the patch (I was more focused on the actual transform).
>
> -Eli
>
> --
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
> Foundation Collaborative Project
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180517/782cdff8/attachment.html>