[PATCH] D45559: [WebAssembly] Add Wasm personality and usesWindowsEHInstructions()

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: include/llvm/Analysis/EHPersonalities.h:65-92
 inline bool isFuncletEHPersonality(EHPersonality Pers) {
   switch (Pers) {
   case EHPersonality::MSVC_CXX:
   case EHPersonality::MSVC_X86SEH:
   case EHPersonality::MSVC_Win64SEH:
   case EHPersonality::CoreCLR:
     return true;
----------------
These two functions are _really_ confusing because the usesWindowsEHInstructions returns true for Wasm.

I think the function which returns true for wasm should be called `isScopedEHPersonality`.
The one which is only true for MSVC & CoreCLR should be called `isFuncletEHPersonality`

I think anything else really invites confusion.


Repository:
  rL LLVM

https://reviews.llvm.org/D45559