[PATCH] D46775: [LICM] Preserve DT and LoopInfo specifically

Michael Zolotukhin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 14:33:37 PDT 2018


mzolotukhin added inline comments.


================
Comment at: test/Transforms/LICM/pr37323.ll:1-2
+;RUN: opt -loop-simplify -postdomtree -licm -adce -S -o - %s | FileCheck %s
+;RUN: opt -passes='loop-simplify,require<postdomtree>,require<opt-remark-emit>,loop(licm),function(adce)' -S -o - %s | FileCheck %s
+
----------------
junbuml wrote:
> mzolotukhin wrote:
> > By the way, do we have something like `-verify-dom-tree` for PostDT? It would be cleaner to explicitly verify postdom tree here than calling ADCE and hoping it crashes.
> The same tag (-verify-dom-info) seem to cover PostDT's verifyAnalysis as well.  Using -verify-dom-info, I confirmed that this test crash in PostDT's verifyAnalysis without this change.
Thanks for checking! Also, speaking of reducing the test case further- can we get rid of `-loop-simplify` (i.e. replace the test with the output of `loop-simplify`) and `-adce`?


https://reviews.llvm.org/D46775





More information about the llvm-commits mailing list