[PATCH] D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

There are a few things that can be improved in this patch, but I think that changing everything before submitting is not necessary. Please go ahead and submit. I'll make a follow-up change after that.



================
Comment at: lld/ELF/Driver.cpp:822-823
+        error(
+            "thinlto-object-suffix-replace expects 'old;new' format, but got " +
+            S.substr(30));
     } else if (!S.startswith("/") && !S.startswith("-fresolution=") &&
----------------
rdhindsa wrote:
> ruiu wrote:
> > nit: it is perhaps better to split the long literal string into two like this
> > 
> >   error("thinlto-object-suffix-replace expects 'old;new' format, "
> >         "but got " + S.substr(30));
> > 
> > so that the code looks better.
> clang-format updates by splitting (" but got " + S.substr(30));) to two lines .
This is much uglier than before, but I'd think we should fight against clang-format. I'd just concatenate the two strings into one literal string just like before.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46608