[PATCH] D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h:32
+#if ((SI_POSIX != 0) == (SI_WINDOWS != 0)) && !SANITIZER_FUCHSIA \
+  && !SANITIZER_RTEMS
 # error "Windows is not POSIX!"
----------------
waltl wrote:
> alekseyshl wrote:
> > How SANITIZER_FUCHSIA and SANITIZER_RTEMS are related to "Windows is not POSIX!" message? Both are not Windows indeed.
> The check was from r309536 back when a port was either Windows or
> POSIX, predating Fuchsia/RTEMS.  Even back then the error message was
> a little cryptic as it would fire when a port is neither.
> 
> I can rewrite this to be slightly more clear, but I wonder whether we need
> this check at all?  Vitaly can you weigh in?
> 
> 
It feels like now it should be 

  #if SI_WINDOWS && SI_POSIX
  # error "Windows is not POSIX!"
  #endif

to keep the original check around.


Repository:
  rL LLVM

https://reviews.llvm.org/D46454