[PATCH] D46426: [SROA] Handle PHI with multiple duplicate predecessors

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 12:12:41 PDT 2018


dberlin added a comment.

1. If this is common enough, should we just have a unique_predecessors iterator?

(unfortunately, std::unique won't work here because preds are not sorted)

2. I don't think it's worth issuing an assert here if the verifier already verifies it.

If we don't add a unique_processor, can you just use SmallPtrSet<BasicBlock *> HandledPreds, and insert/check whether the pred has been handled?


Repository:
  rL LLVM

https://reviews.llvm.org/D46426





More information about the llvm-commits mailing list