[PATCH] D46847: [WebAssembly] Move toString helpers to BinaryFormat. NFC.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 11:41:01 PDT 2018


sbc100 added a comment.

I can't reproduce those failures locally.   I also build with BUILD_SHARED_LIBS=ON so I would expect to see the same errors as you.

Can you see how RandomAccessVisitorTest.cpp makes use of BinaryFormat/Wasm.h?  Your fix looks find to me though.  Is it just those two targets that fail?


Repository:
  rL LLVM

https://reviews.llvm.org/D46847





More information about the llvm-commits mailing list