[PATCH] D46966: [lld] Use a real timestamp, with the option to use hash or explicit value

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: lld/COFF/Writer.cpp:1195
 
-  uint32_t Hash = static_cast<uint32_t>(xxHash64(OutputFileData));
+  uint32_t Timestamp = Config->Timestamp;
+  if (Config->TimestampIsHash)
----------------
ruiu wrote:
> Do you need this temporary variable?
No, but with a ternary operator I would have to use a line break, and I think it's easier to read with no line breaks.  I can change it if you like though.


https://reviews.llvm.org/D46966