[PATCH] D46819: [llvm-objcopy] Add --keep-symbol (-K) option

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added a comment.

@paulsemel, as i said, there are 2 (similar but separate) issue. 
I'm mostly concerned with the fact that we incorrectly remove the symbols table if --strip-all -K foo is specified because it's a real world use-case.
As @jhenderson suggested

  >Instead I'd suggest we need to do two things: 1) If Config.StripAll is set, remove a symbol, unless it is marked as keep. 2) If Config.StripAll is set, and the symbol table is empty (i.e. no symbols were marked as 
  >keep), we strip the symbol table.

i think this is how it should work, so i completely agree with James.
Does it sound good to you ?


Repository:
  rL LLVM

https://reviews.llvm.org/D46819