[PATCH] D46898: Give shared modules in unittests the platform-native extension, make PipSqueak a MODULE

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 09:24:04 PDT 2018


thakis added a comment.

Aha, they used to be different before https://reviews.llvm.org/rL201316

In theory, I suppose LLVM_PLUGIN_EXT is more correct with that history, but in practice I suggest I use LTDL_SHLIB_EXT here and then replace LLVM_PLUGIN_EXT with LTDL_SHLIB_EXT everywhere else (not too many uses) in a follow-up since in the LLVM build shared libraries and loadable modules have the same extension.


https://reviews.llvm.org/D46898





More information about the llvm-commits mailing list