[PATCH] D46907: [llvm-mca] Introduce a sequential container of Stages

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: tools/llvm-mca/Backend.h:81
         Cycles(0) {
+    appendStage(std::move(InitialStage));
     HWS->setDispatchUnit(DU.get());
----------------
andreadb wrote:
> What if we initialize this stage outside of Backend.h ?
> Ideally, the Backend should be empty to start. It shouldn't be populated by the constructor; instead, users should populate the pipeline by performing multiple calls to method appendStage(). I think that the InitialStage should be added by main in llvm-mca.cpp.
+1. This will make it possible for subtargets to customize this more when we move to a per-subtarget factory.


https://reviews.llvm.org/D46907