[PATCH] D45604: Support for multiarch runtimes layout

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

I only looked a little at the Clang parts (the compiler-rt and libcxx cmake stuff I'm not familiar with). It seems reasonable, and would make it easier to ship a cross-compiler I suppose, but I think folks with a higher-level Clang view need to take a look too.



================
Comment at: clang/lib/Driver/ToolChain.cpp:383
+  SmallString<128> Path(D.ResourceDir);
+  llvm::sys::path::append(Path, D.getDefaultTargetTriple(), "lib",
+                          Prefix + Twine("clang_rt.") + Component + Suffix);
----------------
Why is it using the default target triple here and not the current one? (same for the ToolChain ctor).

And the #ifdefs seems unfortunate.. could Clang just look in the target-specific directory if it exists and fall back otherwise or something?


Repository:
  rL LLVM

https://reviews.llvm.org/D45604