[PATCH] D46821: Update llvm-exegesis to cover latency through another opcode.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 04:44:49 PDT 2018


courbet requested changes to this revision.
courbet added inline comments.
This revision now requires changes to proceed.


================
Comment at: tools/llvm-exegesis/lib/MCInstrDescView.h:62
+  const llvm::MCPhysReg *ImplicitReg = nullptr; // Set for Implicit Op.
+  mutable llvm::Optional<Variable> Variable;    // Set for Explicit Op.
+};
----------------
this breaks the build in -Wall mode. Use `Var`.


================
Comment at: tools/llvm-exegesis/lib/MCInstrDescView.h:82
+
+  const Operand *Operand; // Pointer to an Explicit Register Operand.
+  llvm::MCPhysReg Reg;
----------------
ditto


Repository:
  rL LLVM

https://reviews.llvm.org/D46821





More information about the llvm-commits mailing list