[PATCH] D46893: [CVP] Require DomTree for new Pass Manager

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 04:32:35 PDT 2018


dmgreen updated this revision to Diff 147048.
dmgreen added a reviewer: dberlin.
dmgreen added a comment.

I've done some plumbing to pass DT directly through to where it is used. The only other use of SQ is into SimplifyInstruction. I hope this makes the use of getBestSimplifyQuery OK. If not, which analyses should be used to create it? All of them (DT, DL, TLI and AC)? And why do we have getBestSimplifyQuery? ;)

I've also added new pass manager run lines to a couple of tests. Add.ll fails without requiring the DT.


https://reviews.llvm.org/D46893

Files:
  lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
  test/Transforms/CorrelatedValuePropagation/add.ll
  test/Transforms/CorrelatedValuePropagation/phi-common-val.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46893.147048.patch
Type: text/x-patch
Size: 4076 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180516/65aaa946/attachment.bin>


More information about the llvm-commits mailing list