[PATCH] D45748: [RISCV] Separate base from offset in lowerGlobalAddress

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

I've started a discussion on GlobalAddress lowering strategy on llvm-dev here: http://lists.llvm.org/pipermail/llvm-dev/2018-May/123359.html

Your peephole code seems well written and really solid, but I'd like to discuss the dagcombiner approach some more.  The sort of approach taken in https://reviews.llvm.org/rL330630 seems to catch the cases discussed in this thread and has a simpler implementation.


https://reviews.llvm.org/D45748