[PATCH] D45549: [DWARF v5] improved support for .debug_rnglists/consumer

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 02:22:42 PDT 2018


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Looks good to me, thanks Wolfgang!



================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:366
+  if (Error E = RngList.extract(Data, HeaderOffset, End, &Offset)) {
+    llvm::consumeError(std::move(E));
+    return None;
----------------
Would it be worth propagating the error and have this function return an `Expected<>`? 


https://reviews.llvm.org/D45549





More information about the llvm-commits mailing list