[PATCH] D46886: Escape ]]> in xunit xml output

Chris Matthews via llvm-commits llvm-commits at lists.llvm.org
Tue May 15 17:41:56 PDT 2018


Updated in r332423 and r332424.

> On May 15, 2018, at 10:07 AM, Chris Matthews via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> The test does not care what the return code of lit is, just that the xml output is correct.
> 
>> On May 15, 2018, at 10:05 AM, Dan Liew via Phabricator <reviews at reviews.llvm.org> wrote:
>> 
>> delcypher added a comment.
>> 
>> In https://reviews.llvm.org/D46886#1099798, @cmatthews wrote:
>> 
>>> There is a test case that intentionally fails to provide failing output. That makes lit return an error exit value.  Any way to change what lit exits with?
>> 
>> 
>> Not that I know of. But if you're expecting lit to return a non zero exit code should you run `not %{lit} ...` instead?
>> 
>> 
>> Repository:
>> rL LLVM
>> 
>> https://reviews.llvm.org/D46886
>> 
>> 
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list