[PATCH] D46920: [MachineOutliner] Don't outline instructions that modify SP.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 15 17:22:18 PDT 2018


efriedma created this revision.
efriedma added a reviewer: jpaquette.
Herald added a reviewer: javed.absar.

This breaks the code which saves and restores LR, so we can't outline without doing something more complicated for stack adjustment.

Found by inspection; we get lucky in most cases because getMemOpInfo only handles STRWpost, not any other pre/post-increment forms. But it hits a couple of artificial testcases in the tree.


Repository:
  rL LLVM

https://reviews.llvm.org/D46920

Files:
  lib/Target/AArch64/AArch64InstrInfo.cpp
  test/CodeGen/AArch64/machine-outliner-remarks.ll
  test/CodeGen/AArch64/machine-outliner.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46920.146968.patch
Type: text/x-patch
Size: 7840 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180516/39081571/attachment.bin>


More information about the llvm-commits mailing list