[PATCH] D46886: Escape ]]> in xunit xml output

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

In https://reviews.llvm.org/D46886#1099773, @cmatthews wrote:

> Is this an issue you are hitting?  I noticed we spend a lot of time in string replace while writing the xunit files when the output is large (for instance if every test in the test suite fails).  I was hoping the number of replaces we do could go down.
>
> Besides that LGTM.


I currently don't have a test that triggers this behaviour but I believe I originally did hit this when I first implemented this escaping. Will python return a new string if the `]]>` is not included in the input? If not I doubt this adds that much overhead compared to the tons of replacements that were needed to replace all XML chars before.

Regarding the `|| true`: I guess that should just be `not llvm-lit` instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D46886