[PATCH] D46886: Escape ]]> in xunit xml output

[Chris Matthews via llvm-commits]

There is a test case that intentionally fails to provide failing output. That makes lit return an error exit value.  Any way to change what lit exits with?

> On May 15, 2018, at 9:54 AM, Dan Liew via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> delcypher added inline comments.
> 
> 
> ================
> Comment at: utils/lit/tests/xunit-output.py:2
> # Check xunit output
> # RUN: %{lit} --xunit-xml-output %t.xunit.xml %{inputs}/xunit-output || true
> +# If xmllint is installed verify that the generated xml is well-formed
> ----------------
> @cmatthews 
> Wait. I know this isn't part of the patch but what's that `|| true` doing there? That's ignoring the exit code of `lit`. Do we really want to do that?
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D46886
> 
> 
>