[PATCH] D46843: Rename three cxx files in unittests to cpp.

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In https://reviews.llvm.org/D46843#1098959, @philip.pfaffe wrote:

> Something is off with the diff. E.g. the file `TestPlugin.cpp` doesn't exist, yet the diff contains modifications. Did you miss a local commit?


That's how `svn diff` looks after `svn mv`. Maybe you use git (which doesn't have a native "move file" operation) and aren't used to seeing this type of diff?



================
Comment at: unittests/Passes/CMakeLists.txt:1
+# Hack to bypass LLVM's CMake source checks so we can have both a library and
+# an executable built from this directory.
----------------
philip.pfaffe wrote:
> It's not a hack, but the purpose of that setting. So just document the intent directly.
Fair enough. This wording is used in a few places (http://llvm-cs.pcc.me.uk/?q=Hack+to+bypass+LLVM); will change those too once this lands.


https://reviews.llvm.org/D46843