[PATCH] D46853: AMDGPU: Add disasm tests for deep learning instructions + fix v_fmac_f32 disasm

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 15 00:37:15 PDT 2018


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:244-247
   if (Res && (MI.getOpcode() == AMDGPU::V_MAC_F32_e64_vi ||
               MI.getOpcode() == AMDGPU::V_MAC_F32_e64_si ||
-              MI.getOpcode() == AMDGPU::V_MAC_F16_e64_vi)) {
+              MI.getOpcode() == AMDGPU::V_MAC_F16_e64_vi ||
+              MI.getOpcode() == AMDGPU::V_FMAC_F32_e64_vi)) {
----------------
Could we avoid this problem in the future by testing for a tied src2 operand?


https://reviews.llvm.org/D46853





More information about the llvm-commits mailing list