[PATCH] D46829: [BreakCriticalEdges] Require DominatorTree when using the old pass manager

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

In https://reviews.llvm.org/D46829#1098592, @efriedma wrote:

> Like I said in the bug, I would rather fix BranchProbabilityInfoWrapperPass::getAnalysisUsage.


Alright, I'll do that then.

I can't say I really understand though.

What if we in some completely other situation, without running BranchProbabilityInfo, do BreakCriticalEdges and LI is available and DT isn't?
Then BreakCriticalEdges will (try to) update LI, but since there is no DT, the same assert will trigger again? Or what is it I'm missing?


https://reviews.llvm.org/D46829