[PATCH] D46825: [VPlan] Add moveAfter to VPRecipeBase.

[Diego Caballero via Phabricator via llvm-commits]

dcaballe added a comment.

Thanks for the unittest, Florian! I will be very useful!



================
Comment at: lib/Transforms/Vectorize/VPlan.h:543
+  /// the VPBasicBloack that MovePos lives in, right after MovePos.
+  void moveAfter(VPRecipeBase *MovePos);
 };
----------------
instruction -> recipe
VPBasicBloack -> VPBasicBlock

I wonder if it would be better to start a VPInstructionUtils and move this utility there, similar to what I did with VPBlockUtils in `D44338`.


================
Comment at: lib/Transforms/Vectorize/VPlan.h:916
+  /// Return a reference to the list with recipes.
+  RecipeListTy &getRecipes() { return Recipes; }
+
----------------
Just for my understanding, wouldn't it be possible to use `getSublistAccess`?


https://reviews.llvm.org/D46825