[PATCH] D44888: [RISCV] Default enable linker relaxation and add -mrelax, -mno-relax flags

Shiva Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 14 19:01:00 PDT 2018


shiva0217 added inline comments.


================
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:130
+  // which may override the defaults.
+  handleTargetFeaturesGroup(Args, Features, options::OPT_m_riscv_Features_Group);
 }
----------------
kito-cheng wrote:
> This part should  move to the begin of the function, otherwise it never executed if `Exts` is empty string.
> 
Hi Kito. I have rebased the patch to D45465. Could you help me to check when you download raw diff and apply with `patch -p0<` does it still patch to the wrong function?


Repository:
  rL LLVM

https://reviews.llvm.org/D44888





More information about the llvm-commits mailing list