[PATCH] D46477: [AARCH64] Gang up loads and stores (for memcpy) for pairing.

[Sebastian Pop via Phabricator via llvm-commits]

sebpop accepted this revision.
sebpop added a comment.
This revision is now accepted and ready to land.

LGTM with some minor changes.



================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:2520
+  /// When memcpy is inline based on MaxStoresPerMemcpy, specify maximum number
+  /// of store instructions that you can want to keep tother. This helps in
+  /// pairing and vectorazation later on.
----------------
sebpop wrote:
> s/that you can want//
> s/tother/together/
> 
s/that you can want//


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5402
+  if (NumLdStInMemcpy) {
+  // Only if we have load/stores because of memcpy. It maybe that mempy
+  // might be converted to memset if it's memcpy of constants. In that case,
----------------
sebpop wrote:
> The first part is not a sentence, please rewrite in a non-ambiguous way.
> s/maybe/may be/
> s/mempy/memcpy/
s/mempy/memcpy/


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5412
+    }
+    else {
+      // Ld/St less than/equal limit set by target.
----------------
sebpop wrote:
> clang-format
else should be on the same line as close brace:

  } else {


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5241
+
+  // Chain for all loads
+  SDValue LoadToken = DAG.getNode(ISD::TokenFactor, dl, MVT::Other,
----------------
Dot at the end of a sentence: "Use LoadToken to chain all loads."


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5429
+
+        // Residual ld/st
+        if (RemainingLdStInMemcpy) {
----------------
Put a dot at end of a sentence.


Repository:
  rL LLVM

https://reviews.llvm.org/D46477