[PATCH] D41953: [LoopUnroll] Unroll and Jam

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 14 09:09:45 PDT 2018


dmgreen added inline comments.


================
Comment at: test/Transforms/LoopUnrollAndJam/unroll-and-jam.ll:9
+; CHECK: entry:
+; CHECK:   br i1 %or.cond, label %for.outer.preheader, label %for.end
+; CHECK: for.outer.preheader:
----------------
SjoerdMeijer wrote:
> Do we need all these checks? And with all the variable names still there, it looks like a fragile test to me. Same for the other functions below.
I think as we are only running a single pass (not -O3 or an entire backend), it should be relatively stable.

I've updated this one to be auto generated and show the entire code output. The others are usually testing some small portion of the resulting function.


https://reviews.llvm.org/D41953





More information about the llvm-commits mailing list