[PATCH] D46821: Update llvm-exegesis to cover latency through another opcode.

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 14 07:21:45 PDT 2018


gchatelet planned changes to this revision.
gchatelet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/BenchmarkRunner.cpp:85
 
-  InstrBenchmark.Measurements =
-      runMeasurements(State, Function, NumRepetitions);
+  const ExecutableFunction EF(State.createTargetMachine(),
+                              getObjectFromFile(*ExpectedObjectPath));
----------------
courbet wrote:
> let's avoid creating a target machine several times. It could be a State member.
Unfortunately the target machine is consumed by the `ExecutableFunction` to create the `ExecutionEngine`.
I'm not sure if I can reuse the `ExecutionEngine`, I'll try this in a following Patch to address the FIXMEs.


Repository:
  rL LLVM

https://reviews.llvm.org/D46821





More information about the llvm-commits mailing list