[PATCH] D46748: [CodeGen/AccelTable]: Handle -dwarf-linkage-names=Abstract correctly

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 14 03:56:54 PDT 2018


JDevlieghere added a comment.

In https://reviews.llvm.org/D46748#1097614, @labath wrote:

> In https://reviews.llvm.org/D46748#1097598, @JDevlieghere wrote:
>
> > LGTM. I wonder if we should we have a negative test as well?
>
>
> There's an `--implicit-check-not` in the `ABSTRACT` case. Is that what you meant? I can try to rearrange the RUN lines to make it more obvious.


I meant for the missing `++NumErrors;`. But on checking the existing test (`debug-names-verify-entries.s`) we already check the return value, which just happens to be non-zero because of the other failures. I'm okay with keeping it as is.


Repository:
  rL LLVM

https://reviews.llvm.org/D46748





More information about the llvm-commits mailing list