[PATCH] D46792: [LLVM-C] Add Bindings For Module Flags

Robert Widmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 13 22:49:08 PDT 2018


CodaFi added inline comments.


================
Comment at: include/llvm-c/Core.h:721
+ * Returns the module flags as an array of flag-key-value triples.  The caller
+ * is responsible for freeing this array.
+ *
----------------
whitequark wrote:
> The caller is going to free this array how? LLVM provides dispose functions but I don't see one here.
The data for the entries is owned by the module, the array is just an adapter for those entries - the user need only `free`.  I can provide an explicit dispose for this in case we decide to change that user model or for clarity if you want.


Repository:
  rL LLVM

https://reviews.llvm.org/D46792





More information about the llvm-commits mailing list