[PATCH] D46738: [DebugInfo] Fix PR37395.

Hsiangkai Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 13 22:19:42 PDT 2018


HsiangKai added a comment.

In https://reviews.llvm.org/D46738#1096218, @davide wrote:

> The fix itself looks fine, but I'll defer to @aprantl.
>  Do you need anybody to commit this for you?


@aprantl Do you have any comments?
@davide I could ask for Shiva Chen to commit this for me, thanks anyway.



================
Comment at: test/DebugInfo/Generic/PR37395.ll:1
+; RUN: opt -O1 -S %s | FileCheck %s
+; CHECK: DILabel
----------------
davide wrote:
> This is too fragile. The test should run a single pass.
I use the steps provided by Zhendong Su to reproduce the bug in https://bugs.llvm.org/show_bug.cgi?id=37395. I didn't get the idea that 'run a single pass'. Could you give more information or examples to improve the test case?


Repository:
  rL LLVM

https://reviews.llvm.org/D46738





More information about the llvm-commits mailing list