[PATCH] D46800: [X86DomainReassignment] Don't compare stack-allocated values by address

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 13 15:57:54 PDT 2018


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86DomainReassignment.cpp:336
 
+  void dump(const MachineRegisterInfo *MRI) const {
+    dbgs() << "Registers: ";
----------------
Won't this be unused in release builds? Will that cause an error?


================
Comment at: lib/Target/X86/X86DomainReassignment.cpp:338
+    dbgs() << "Registers: ";
+    bool first = true;
+    for (unsigned Reg : Edges) {
----------------
Capitalize variable name


Repository:
  rL LLVM

https://reviews.llvm.org/D46800





More information about the llvm-commits mailing list