[llvm] r332177 - [x86] Remove a comment obviated by r330269. Should have deleted the

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Sat May 12 14:28:53 PDT 2018


Author: chandlerc
Date: Sat May 12 14:28:53 2018
New Revision: 332177

URL: http://llvm.org/viewvc/llvm-project?rev=332177&view=rev
Log:
[x86] Remove a comment obviated by r330269. Should have deleted the
comment in the same revision but missed it.

Thanks to Dimitry Andric for catching this!

Modified:
    llvm/trunk/lib/Target/X86/X86FlagsCopyLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86FlagsCopyLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FlagsCopyLowering.cpp?rev=332177&r1=332176&r2=332177&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86FlagsCopyLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86FlagsCopyLowering.cpp Sat May 12 14:28:53 2018
@@ -630,11 +630,6 @@ std::pair<unsigned, bool> X86FlagsCopyLo
 void X86FlagsCopyLoweringPass::insertTest(MachineBasicBlock &MBB,
                                           MachineBasicBlock::iterator Pos,
                                           DebugLoc Loc, unsigned Reg) {
-  // We emit test instructions as register/immediate test against -1. This
-  // allows register allocation to fold a memory operand if needed (that will
-  // happen often due to the places this code is emitted). But hopefully will
-  // also allow us to select a shorter encoding of `testb %reg, %reg` when that
-  // would be equivalent.
   auto TestI =
       BuildMI(MBB, Pos, Loc, TII->get(X86::TEST8rr)).addReg(Reg).addReg(Reg);
   (void)TestI;




More information about the llvm-commits mailing list