[PATCH] D46456: [asan] Add support for Myriad RTEMS memory map

[Walter Lee via Phabricator via llvm-commits]

waltl marked 5 inline comments as done.
waltl added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_mapping.h:294
 #if ASAN_FIXED_MAPPING
+#if SANITIZER_MYRIAD2
+static uptr kHighMemEnd = 0;
----------------
vitalybuka wrote:
> waltl wrote:
> > vitalybuka wrote:
> > > you can use ASAN_FIXED_MAPPING and platform specific FindDynamicShadowStart() 
> > Can you clarify?  If I use ASAN_FIXED_MAPPING I have to clone the definitions in this header, and initialize them in the header and not FindDynamicShadowStart().
> > 
> Sorry, I meant to write "NOT ASAN_FIXED_MAPPING" and reset pointers in runtime from platform specific FindDynamicShadowStart
Myriad port doesn't use FindDynamicShadowStart, but I've put the initialization in InitializeShadowMemory() defined in asan_rtems.cc (see https://reviews.llvm.org/D46468).



Repository:
  rL LLVM

https://reviews.llvm.org/D46456