[PATCH] D46558: Condition usage of locale stdlib functions on Android API version

[Tom Anderson via Phabricator via llvm-commits]

thomasanderson added a comment.

Hm.. It looks like ToT libc++ is only missing 3 functions: strtoll_l, strtoull_l, and strtold_l.  We could just add these in locale_bionic.h after line 33 (all of them were added in __ANDROID_API__ 21 https://android.googlesource.com/platform/bionic/+/master/libc/include/stdlib.h#194).  These functions are not in __posix_l_fallback.h

Should we do this or just land the CL as-is, which reverts https://reviews.llvm.org/rL330045 and includes __strtonum_fallback.h.  I think I prefer the former.


https://reviews.llvm.org/D46558