[PATCH] D46339: [GlobalISel][Legalizer] LegalizerInfo verifier: Follow Up

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Fri May 11 15:05:37 PDT 2018


Yes, please remove these.

Simplify-mir may get smarter and eliminate more stuff and we don't
want to have to patch the check lines.

2018-05-11 13:18 GMT-07:00 Roman Tereshin via Phabricator
<reviews at reviews.llvm.org>:
> rtereshin added inline comments.
>
>
> ================
> Comment at: test/CodeGen/AArch64/GlobalISel/legalize-inttoptr-xfail-1.mir:1
>  # RUN: not llc -mtriple=aarch64-- -run-pass=legalizer -simplify-mir %s -o - 2>&1 | FileCheck %s
>  # REQUIRES: asserts
> ----------------
> qcolombet wrote:
>> Out-of-curiosity, why is the simplify-mir option required here?
> It's not required, but I find it useful: if a test fails I often just copy-paste the command line used as reported by `llvm-lit` quite mechanically to see a broader context than `FileCheck` included in the error message, and it's nice if it happens to produce a shorten output.
>
> I can stop committing these of course.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D46339
>
>
>


More information about the llvm-commits mailing list