[PATCH] D46770: [AMDGPU] Fix compilation failure when IR contains comdat

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 11 13:44:06 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL332137: [AMDGPU] Fix compilation failure when IR contains comdat (authored by yaxunl, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D46770?vs=146400&id=146406#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D46770

Files:
  llvm/trunk/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
  llvm/trunk/test/CodeGen/AMDGPU/comdat.ll


Index: llvm/trunk/test/CodeGen/AMDGPU/comdat.ll
===================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/comdat.ll
+++ llvm/trunk/test/CodeGen/AMDGPU/comdat.ll
@@ -0,0 +1,19 @@
+; RUN: llc -mtriple amdgcn-amd-amdhsa -filetype=obj <%s \
+; RUN:   | llvm-readobj -symbols - | FileCheck %s
+
+; CHECK: Name: func1
+; CHECK: Section: .text.func1
+
+; CHECK: Name: func2
+; CHECK: Section: .text.func2
+
+$func1 = comdat any
+$func2 = comdat any
+
+define amdgpu_kernel void @func1() local_unnamed_addr comdat {
+  ret void
+}
+
+define amdgpu_kernel void @func2() local_unnamed_addr comdat {
+  ret void
+}
Index: llvm/trunk/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
===================================================================
--- llvm/trunk/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
+++ llvm/trunk/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
@@ -197,8 +197,6 @@
   amd_kernel_code_t KernelCode;
   if (STM.isAmdCodeObjectV2(*MF)) {
     getAmdKernelCode(KernelCode, CurrentProgramInfo, *MF);
-
-    OutStreamer->SwitchSection(getObjFileLowering().getTextSection());
     getTargetStreamer()->EmitAMDKernelCodeT(KernelCode);
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46770.146406.patch
Type: text/x-patch
Size: 1171 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180511/2a870a1d/attachment.bin>


More information about the llvm-commits mailing list