[PATCH] D46752: [Analysis] Validate the return type of s(n)printf libcalls

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D46752#1096183, @xbolva00 wrote:

> I commited it again, you do not need to revert your revert.


Thanks - the codebase that triggered the error seems to build fine now still with this reapplied.

In https://reviews.llvm.org/D46752#1096337, @efriedma wrote:

> I'm not convinced this really solves the problem correctly... I mean, obviously we shouldn't crash, but this doesn't deal with the underlying issue: once we transform the internal function, it is no longer the C library function, and that difference may not be reflected in the signature.  See http://lists.llvm.org/pipermail/llvm-dev/2017-October/118578.html .


Hm, indeed, there's clearly more aspects to it. I take it there was no further progress since, on the ideas presented there?


Repository:
  rL LLVM

https://reviews.llvm.org/D46752