[PATCH] D46380: [InstCombine] Extending InstructionSimplify to check OverflowingBinaryOperators and PossiblyExactOperators safety

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a reviewer: efriedma.
spatel added a comment.

I haven't looked at the details of everything that's going on in these folds, but a couple of higher-level points:

1. This is an instsimplify patch - the review title should be changed; there should be minimal tests for each transform under tests/Transforms/InstSimplify.
2. This is using ValueTracking which can be expensive in compile-time - do you have any stats for how often this fires, perf improvements, compile-time regressions? (adding Eli for thoughts about where we would draw that line because I really don't know)


Repository:
  rL LLVM

https://reviews.llvm.org/D46380