[PATCH] D45773: [RISCV] Don't fold symbol diff

Simon Cook via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 11 03:28:32 PDT 2018


simoncook requested changes to this revision.
simoncook added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/MC/MCObjectStreamer.cpp:59
   assert(Hi && Lo);
+  if (TAB->requiresDiffExpressionRelocations())
+    return None;
----------------
kito-cheng wrote:
> I got compile error here:
> 
> MCObjectStreamer.cpp:94:7: error: ‘TAB’ was not declared in this scope
Hi Kito. Ed is out of the office today so I can't update this diff right now (I'll ask him to do this on Monday), but I've rebased it and this line should now be

```
  if (getAssembler().getBackendPtr()->requiresDiffExpressionRelocations())
```


https://reviews.llvm.org/D45773





More information about the llvm-commits mailing list